[Webkit-unassigned] [Bug 14111] Autogenerate Event JS binding

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14111


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #14991|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2007-06-14 20:53 PDT -------
(From update of attachment 14991)
Is there no way to avoid special-casing clipboardData and dataTransfer? Can't
we just move those to the appropriate event classes?

+    // FIXME: Is this lock necessary?
+    KJS::JSLock lock;

Seems clear that it is.

+            if (WebCore::JSUnprotectedEventListener* listener =
static_cast<WebCore::JSUnprotectedEventListener*>(m_impl->onReadyStateChangeListener()))
Why is the WebCore prefix needed?

-        [OldStyleObjC] void initEvent(in DOMString eventTypeArg, 
+        [OldStyleObjC] void initEvent(in AtomicString eventTypeArg, 

This seems wrong. The API should be DOMString even though the implementation is
AtomicString.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.