[Webkit-unassigned] [Bug 14740] Hierarchical layout tests and platform organization

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14740





------- Comment #6 from aroben at apple.com  2007-07-30 20:43 PDT -------
(In reply to comment #4)
> Created an attachment (id=15753)
 --> (http://bugs.webkit.org/attachment.cgi?id=15753&action=view) [edit]
> wip v2
> 
> > +my $platform;
> >
> > I think it would be good to define $platform to its default setting before
> > parsing the options. Then you can show the default in the usage output.
> 
> Done - though I feel dirty the way I did this (but maybe that's just me).
> 
> > +my $platformTestDirectory = $testDirectory . "/platform/";
> >
> > It would be nice to use File::Spec->catdir() instead of building up these paths
> > manually.
> > 
> > +} elsif (isTiger()) {
> > +    $platformTestDirectory .= "mac-leopard";
> > +} elsif (isLeopard()) {
> > +    $platformTestDirectory .= "mac";
> > 
> > I think these are reversed.
> 
> Done and done.
> 
> I'm sure there are nitpicks left in here which is why I'm not putting it up for
> review.  Another reason is that platform specific tests do not use the
> resources of lower levels if applicable. So say you had a
> platform/mac-leopard/css1/basic test that relied on one of the resources in the
> css1/resources folder - that platform-specific test would require it's own copy
> of those resources in platform/mac-leopard/css1/resources - is that an issue
> and if so, how big?

   Well, the test could hard-code the path to the shared resource (e.g.,
"../../../../css1/basic/resources/whatever.jpg"). We could eventually decide to
move all resources to some shared location, though I imagine there will be some
platform-specific resources at some point.

> 


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.