[Webkit-unassigned] [Bug 14740] Hierarchical layout tests and platform organization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 19:56:52 PDT 2007


------- Comment #5 from aroben at apple.com  2007-07-30 19:56 PDT -------
(From update of attachment 15753)
+sub buildTestHierarchy();

I think buildTestHierarchy is a misleading name, because this isn't building up
an hierarchy of tests. Maybe buildPlatformHierarchy would be better?

+} elsif (isTiger()) {
+    $platform = "mac";

We should probably just say isOSX() here, since we want OS X v. 10.6 to match
this, once it exists.

+if ($platformOverride) {
+    $platform = $platformOverride;

There's no need for a separate $platformOverride variable. The --platform
option can just set $platform directly.

This is looking really close! I think all we have left is generating new
results, right?

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list