[Webkit-unassigned] [Bug 14626] Make bidiReorderCharacters independent of RenderBlock

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 18 12:39:25 PDT 2007


mitz at webkit.org changed:

           What    |Removed                     |Added
  Attachment #15562|review?                     |
               Flag|                            |
  Attachment #15562|0                           |1
        is obsolete|                            |
  Attachment #15566|                            |review?
               Flag|                            |

------- Comment #10 from mitz at webkit.org  2007-07-18 12:39 PDT -------
Created an attachment (id=15566)
 --> (http://bugs.webkit.org/attachment.cgi?id=15566&action=view)
Take bidiReorderCharacters out of RenderBlock

(In reply to comment #9)
> Please don't do this in the header.
> +using namespace WTF::Unicode;


> Since this is ref-counted, can this inherit from Shared instead of doing its
> own?
> +class BidiContext {

Thanks, now it does.

> in BidiContext.cpp:
> It seems arbitrary to put this in the .cpp file when so much implementation is
> BidiResolver.h

Moved to BidiContext.h.

> in BidiResolver.h:
> Why not put each of the classes in this file into it's own header?

Because they are small and those headers will not be included directly by any
file besides BidiResolver.h.

> Please don't do this in the header.
> +using namespace WTF::Unicode;


> Put a space after the if.
> +            if(dir == LeftToRight || dir == ArabicNumber || dir ==
> EuropeanNumber)

Done for all "if(", but otherwise style cleanup of existing code is outside the
scope of this patch.

> Put spaces around the %'s in few places including
> +        if (runDir == RightToLeft) {
> +            if (level%2) // we have an odd level


Renamed BidiRunBase to BidiCharacterRun. Note that in this patch I am not
renaming existing bidi.cpp types such as BidiIterator, BidiState and BidiRun,
although eventually I would like to (at which time BidiStatus could be renamed
BidiState or BidiResolverState).

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list