[Webkit-unassigned] [Bug 14626] Make bidiReorderCharacters independent of RenderBlock

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=14626





------- Comment #9 from sam at webkit.org  2007-07-18 10:47 PDT -------
Preliminary pass of the code.

in BidiContext.h:

Please don't do this in the header.
+using namespace WTF::Unicode;

Since this is ref-counted, can this inherit from Shared instead of doing its
own?
+class BidiContext {

in BidiContext.cpp:

It seems arbitrary to put this in the .cpp file when so much implementation is
BidiResolver.h

in BidiResolver.h:

Why not put each of the classes in this file into it's own header?

Please don't do this in the header.
+using namespace WTF::Unicode;

Put a space after the if.
+            if(dir == LeftToRight || dir == ArabicNumber || dir ==
EuropeanNumber)

Put spaces around the %'s in few places including
+        if (runDir == RightToLeft) {
+            if (level%2) // we have an odd level


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.