[Webkit-unassigned] [Bug 10773] Memory usage grows when reloading google.com/ig

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=10773


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12568|review?                     |review+
               Flag|                            |




------- Comment #27 from darin at apple.com  2007-01-20 08:14 PDT -------
(From update of attachment 12568)
+    //we need to mark any DOM wrappers associated with this document

Normally we put spaces after the "//" for comments. Also, I'm not sure this
comment is good. It just repeats what the function name says. If the issue is
clarifying that these are "wrappers" then I think the ScriptInterpreter
function should be named markDOMWrappersForDocument. And lets omit the comment.

         NodeMap::iterator nodeEnd = nodeDict->end();
+        
         for (NodeMap::iterator nodeIt = nodeDict->begin(); nodeIt != nodeEnd;
++nodeIt) {

I don't think that adding this blank line improves paragraphing/formatting.

Is there any way to test this in a regression test?

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.