[Webkit-unassigned] [Bug 12851] improve gdk's notImplemented() macro

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12851


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13309|review?                     |review+
               Flag|                            |




------- Comment #2 from aroben at apple.com  2007-02-21 22:41 PDT -------
(From update of attachment 13309)
+#define notImplementedGdk() do { \
+    static int count; \
+    if (!count && !getenv("DISABLE_NI_WARNING")) \
+        fprintf(stderr, "FIXME: UNIMPLEMENTED %s %s:%d\n",
WTF_PRETTY_FUNCTION, __FILE__, __LINE__); \
+    ++count; \
+ } while(0)

   Might as well just use a "bool printed" instead of "int count".

   Instead of putting this in config.h, you should probably just create your
own header platform/gdk/NotImplemented.h that only contains this macro.

   You might also want to uncomment any other notImplemented() calls that were
commented out for being too chatty.

   r=me.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.