[Webkit-unassigned] [Bug 12851] improve gdk's notImplemented() macro

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=12851


kkowalczyk at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13309|                            |review?
               Flag|                            |




------- Comment #1 from kkowalczyk at gmail.com  2007-02-21 22:30 PDT -------
Created an attachment (id=13309)
 --> (http://bugs.webkit.org/attachment.cgi?id=13309&action=view)
improve gdk's notImplemented() macro

Improve gdk's notImplemented() macro():
* as suggested per Adam Roben in http://bugs.webkit.org/show_bug.cgi?id=12785,
only print once per function, so that frequently called functions don't clutter
the output
* rename to notImplementedGdk() to give it a unique name (so that it doesn't
clash with notImplemented() for other platforms)
* Don't print the warning if DISABLE_NI_WARNING env variable is set.

Is it ok to move notImplementedGdk() to some common place (e.g. config.h) to
avoid duplicating the code? If yes, I'll submit a patch for that in the future
(I renamed the macro to notImplementedGdk() in anticipation of that).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.