[Webkit-unassigned] [Bug 12786] Crashes on arm due to different struct packing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 16 23:28:26 PST 2007


kkowalczyk at gmail.com changed:

           What    |Removed                     |Added
  Attachment #13207|                            |review?
               Flag|                            |
  Attachment #13198|0                           |1
        is obsolete|                            |

------- Comment #3 from kkowalczyk at gmail.com  2007-02-16 23:28 PDT -------
Created an attachment (id=13207)
 --> (http://bugs.webkit.org/attachment.cgi?id=13207&action=view)
updated patch

As per review comments:
* changed the test to #if COMPILER(GCC) && PLATFORM(ARM)
* move COMPILE_ASSERT to corresponding .cpp files to avoid #including
Assertions.h in *.h files

I don't think putting the PACK_STRUCT definition to config.h would be good
since it would require #including "config.h" in ustring.h and
DeprecatedString.h (at the moment no *.h files includes "config.h"). Platform.h
maybe? But that would require #including "Platform.h" in ustring.h and
DeprecatedString.h i.e. potentially longer compile times.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list