[Webkit-unassigned] [Bug 12786] Crashes on arm due to different struct packing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 16 22:48:26 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12786


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13198|review?                     |review-
               Flag|                            |




------- Comment #2 from oliver at apple.com  2007-02-16 22:48 PDT -------
(From update of attachment 13198)
I'd be tempted to make it #if PLATFORM(ARM) (do we have that?) and if all
possible move the compileassertion (and the Assertion.h include into a C file
(we're already taking a long time to copile, aroben has been attempting to
reduce the number of includes in headers)

Also, it might be worth putting the 
+#if COMPILER(GCC)
+#define PACK_STRUCT __attribute__((packed))
+#else
+#define PACK_STRUCT
+#endif
 into config.h


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list