[Webkit-unassigned] [Bug 12783] curl networking improvements for gdk build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 16 23:07:02 PST 2007


http://bugs.webkit.org/show_bug.cgi?id=12783


oliver at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13195|review+                     |review-
               Flag|                            |




------- Comment #3 from oliver at apple.com  2007-02-16 23:06 PDT -------
(From update of attachment 13195)

+        struct curl_slist *m_customHeaders;   
WebKit style guide is Type* ident
so "struct curl_slist* m_customHeaders"

*  in the wrong place again:
+        ResourceHandle *job;
+        ResourceHandleInternal *d = job->getInternal();
+            char *url = 0;
+        struct curl_slist *headers = 0;
+            const char *header = headerString.latin1().data();
+    char * m_cookieJarFileName; // FIXME: never freed

Otherwise looks reasonable -- but i cannot vouch for correctness, i don't know
gdk at all.  


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list