[Webkit-unassigned] [Bug 12783] curl networking improvements for gdk build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 16 23:01:23 PST 2007


aroben at apple.com changed:

           What    |Removed                     |Added
  Attachment #13195|review?                     |review+
               Flag|                            |

------- Comment #2 from aroben at apple.com  2007-02-16 23:01 PDT -------
(From update of attachment 13195)
+    free((void*)m_url);

   Is this cast to void* really necessary?

+    for (;;) {

   I believe while (true) is a bit more inline with our coding style.

+    void setupPOST(ResourceHandle* job);
+    void setupPUT(ResourceHandle* job);

   You should remove the parameter names here.

   I don't know much about curl, but this code looks sane. r=me.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list