[Webkit-unassigned] [Bug 12160] Linux/Gdk build fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 7 02:03:40 PST 2007


mjs at apple.com changed:

           What    |Removed                     |Added
  Attachment #12995|review?                     |review+
               Flag|                            |

------- Comment #19 from mjs at apple.com  2007-02-07 02:03 PDT -------
(From update of attachment 12995)
I'm not sure ResourceHandleManager::self() is a good name. get() was kind of
vague, but a more typical name for a static method when applying the singleton
pattern like this would be sharedInstance() or just shared(). Otherwise these
changes look fine. r=me and feel free to adjust name when landing if you want.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list