[Webkit-unassigned] [Bug 16222] [GTK] Implement inline search and highlighting of matching strings.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16222


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17654|review?                     |review+
               Flag|                            |




------- Comment #9 from aroben at apple.com  2007-12-02 12:12 PDT -------
(From update of attachment 17654)
+/**
+ * webkit_web_view_search_text:
+ * @web_view: a #WebKitWebView
+ * @text: a string to look for
+ * @forward: wether to find forward or not
+ * @case_sensitive: wether to respect the case of text
+ * @wrap: wether to continue looking at the beginning after reaching the end
+ *
+ * Looks for a specified string inside #web_view.
+ *
+ * Return value: %TRUE on success or %FALSE on failure
+ */
+gboolean webkit_web_view_search_text(WebKitWebView* webView, const gchar*
string, gboolean forward, gboolean caseSensitive, gboolean shouldWrap)

Do the names of parameters in the documentation need to match their names in
the function definition?

+uint Page::markAllMatchesForText(const String& target, bool caseSensitive,
bool highlight, unsigned limit)

This needs to return an unsigned as well.

r=me, but whoever lands this needs to fix the return type of
markAllMatchesForText.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.