[Webkit-unassigned] [Bug 16222] [GTK] Implement inline search and highlighting of matching strings.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16222


christian at twotoasts.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17650|0                           |1
        is obsolete|                            |
  Attachment #17654|                            |review?
               Flag|                            |




------- Comment #8 from christian at twotoasts.de  2007-12-02 11:53 PDT -------
Created an attachment (id=17654)
 --> (http://bugs.webkit.org/attachment.cgi?id=17654&action=view)
Fixed style issues, renamed string to text

I fixed the style issues Adam pointed out. I left the loops for now.

> 102         bool findString(const String&, bool, bool, bool);

I think that must not be const because it may modify the selection and the
focus.

> Hi Christian. What do you think of webkit_web_view_search_text?

In fact I looked through a few gtk functions again and 'text' is probably the
appropriate term. So I renamed it.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.