[Webkit-unassigned] [Bug 13285] Coverity fixes.

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=13285





------- Comment #20 from kkowalczyk at gmail.com  2007-04-04 23:59 PDT -------
(In reply to comment #17)
> (From update of attachment 13967 [edit])
> How does *removing* a NULL-check improve things in this case?  This looks
> incorrect to me.

Coverity complains because this NULL check is, effectively, a no-op. Coverity
sees a check for info_ptr != NULL so it infers that the programmer thinks that
info_ptr can be NULL. But then it sees that info_ptr is blindly dereferenced
anyway. So either the NULL check is wrong or the function will crash anyway in
which case removing the check makes no difference (the function will crash in a
different place).

This is not to say that adding more NULL checks wouldn't be a valid solution -
it's just more invasive change and I was afraid of introducing changes in
behaviour.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.