[Webkit-unassigned] [Bug 13285] Coverity fixes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 23:47:14 PDT 2007


http://bugs.webkit.org/show_bug.cgi?id=13285





------- Comment #18 from kkowalczyk at gmail.com  2007-04-04 23:47 PDT -------
(In reply to comment #15)
> (From update of attachment 13958 [edit])
> This "fix" looks to address a non-existent problem.  If data is NULL then
> newSize is set to 0 and newSize * d->itemSize will also be zero, so data
> will´┐Żnot be dereferenced.

Like I explained in the beginning, even if a given problem is flagged by
coverity because it cannot prove that memcpy() won't reference the possibly
NULL pointer, it's still worth fixing so that when running coverity in the
future won't show the same issue over and over again. It's the same logic you
apply when fixing compiler warnings even if you know that ultimately they're
benign.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list