[Webkit-unassigned] [Bug 11332] SVG support for Linux port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 13 16:37:45 PST 2006


------- Comment #34 from mike.emmel at gmail.com  2006-11-13 16:37 PDT -------
(In reply to comment #33)
> Mike, there are a large number of tabs introduced in your latest patch.  As per
> the coding style guidelines, tabs should not be used for indentation.  There
> are a number of other coding style issues:  several commented out blocks of
> code, incorrect brace placement in class declarations in header files, #include
> statements in arbitrary order rather than sorted alphabetically, and so on. 
> While skimming the patch I also noticed a block of code that looks a little
> suspicious:
> +void FrameLoader::checkLoadCompleteForThisFrame()
> +{
> +    ASSERT(m_client->hasWebView());
> +    notImplemented();
> +    
> +    switch (m_state) {
> +    case FrameStateProvisional: {
> +    }
> +        
> +    case FrameStateCommittedPage: {
> Is it intended for the FrameStateProvisional case to fall through to the
> FrameStateCommittedPage case?  The braces are extraneous either way, but if the
> intent _is_ to fall through I think it could be made more obvious.


I forgot to format.

As far as the code goes that was copied from the mac impl dunno if its right or
not. I do know I can load www.google.com agian. Note the notImplemented call
indicating I did not quite agree with the code either.

Sending a formatting patch.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list