[Webkit-unassigned] [Bug 11332] SVG support for Linux port
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 13 16:14:56 PST 2006
http://bugs.webkit.org/show_bug.cgi?id=11332
------- Comment #33 from bdash at webkit.org 2006-11-13 16:14 PDT -------
Mike, there are a large number of tabs introduced in your latest patch. As per
the coding style guidelines, tabs should not be used for indentation. There
are a number of other coding style issues: several commented out blocks of
code, incorrect brace placement in class declarations in header files, #include
statements in arbitrary order rather than sorted alphabetically, and so on.
While skimming the patch I also noticed a block of code that looks a little
suspicious:
+void FrameLoader::checkLoadCompleteForThisFrame()
+{
+ ASSERT(m_client->hasWebView());
+ notImplemented();
+
+ switch (m_state) {
+ case FrameStateProvisional: {
+ }
+
+ case FrameStateCommittedPage: {
Is it intended for the FrameStateProvisional case to fall through to the
FrameStateCommittedPage case? The braces are extraneous either way, but if the
intent _is_ to fall through I think it could be made more obvious.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list