[Webkit-unassigned] [Bug 7604] calcAbsoluteHorizontalValues() is being getting passed arguments in the wrong order in calcAbsoluteHorizontal()

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7604





------- Comment #2 from sam.weinig at gmail.com  2006-03-15 11:53 PDT -------
Created an attachment (id=7094)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7094&action=view)
first attempt at cleanup

I am attaching a first go at a clean up of the absolute positioning code in
RenderBox.  Among other things, it splits out the replaced element code-path to
correspond with the separation in the css 2.1 spec, it gets rid of the use of a
constant for AUTO, instead using the Length class, and generally cleans up the
code by making variable names more clear, adding comments, and getting rid of
dead code.  

As it is right now, the code has a lot of FIXME's left in it in places where I
was unsure what the correct change should be.  I would appreciate any feedback
on any of these.  If your not sure what I am talking about in the FIXME, please
let me know and I will elaborate. 

The comments are also quite verbose as I have included the text of the spec
completely.  I found having the text in the code very useful while coding it,
but if it is too much, will remove it.  Additionally, I went a little 'const'
crazy, but found it useful in that the compiler would tell me if I was changing
something I really wanted to be const.

Finally, although I said that this patch is just a first attempt, it does work.
 By that I mean it compiles fine and causes no regressions.  I can't attest to
preformance, but my assumption is that it should be a little faster, due to
some straight forward optimizations made and the exclusion of deadcode paths.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.