[Webkit-unassigned] [Bug 7604] calcAbsoluteHorizontalValues() is being getting passed arguments in the wrong order in calcAbsoluteHorizontal()

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7604





------- Comment #1 from sam.weinig at gmail.com  2006-03-06 09:45 PDT -------
Now this is fun.  Upon closer inspection of the code, it seems to me that the
static_distance variable is not even needed in calcAbsoluteHorizontalValues()
as the case when it might be used (when left == AUTO && width != AUTO && right
== AUTO ) is never used.  This is because in calcAbsoluteHorizontal(), if both
left and right == AUTO, one is always set to the static distance before
calcAbsoluteHorizontalValues() is called.

This, however, does not solve the problem of passing the wrong value for pab
(which is the sum of the padding and borders), unless it can somehow be shown
that it is always equal to the static distance, which I can't imagine is true.

The is no way around it, this code is in need of a good cleaning.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.