[Webkit-unassigned] [Bug 9561] REGRESSION: Content property on :before of button causes hang on click or hover

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9561





------- Comment #7 from darin at apple.com  2006-06-25 10:16 PDT -------
(From update of attachment 9019)
I'm not a big fan of functions that have those "do" prefixes. It's always hard
to know how they differ from the version without the "do" prefix. It's just
"stage 2". We should seek out a better name for the non-virtual core
implementation of updatePseudoChild.

In what cases will it ever be good for RenderButton to call doUpdatePseudoChild
on itself rather than on m_inner?

Architecturally, the worst thing here is the knowledge in
RenderContainer::updatePseudoChild that the parent is special when it's a
RenderButton. That needs a comment at least. And we should see what we can do
to avoid this new slightly-fragile linkage between the classes. Even having a
virtual function that was named something cumbersome like
"updatesPseudoChildForChildren" might be better.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.