[Webkit-unassigned] [Bug 9181] Complete DOMUIEvent Obj-C API to reflect UIEvent

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9181


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8864|review?                     |review+
               Flag|                            |




------- Comment #20 from ggaren at apple.com  2006-06-18 11:35 PDT -------
(From update of attachment 8864)
Good work.

I don't think returning the non-public object from the public method is a big
deal. From the public API standpoint, it will just be a DOMUIEvent.

There's no need to use a separate file for non-W3C additions. I don't think
that's how we handle other private-pending-public API. Also, the Objc bindings
will be autogenerated eventually, and our IDL files probably won't distinguish
W3C and non-W3C interfaces.

+                               EXPORTED_SYMBOLS_FILE = "";

How did this line sneak into the project diff? Is it an XCode version quirk, or
will it nuke WebCore's .exp file? I don't *think* it will, since we specify the
.exp file through OTHER_LDFLAGS, not EXPORTED_SYMBOLS_FILE.

Anyway, addressing the comments above is optional.  r=me

Whoever lands this should make sure that WebCore still builds with its .exp
file.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.