[Webkit-unassigned] [Bug 9179] Implement select.options.add() method
bugzilla-daemon at opendarwin.org
bugzilla-daemon at opendarwin.org
Mon Jul 10 07:34:53 PDT 2006
http://bugzilla.opendarwin.org/show_bug.cgi?id=9179
ddkilzer at kilzer.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #9325 is|0 |1
obsolete| |
Attachment #9339| |review?
Flag| |
------- Comment #28 from ddkilzer at kilzer.net 2006-07-10 07:34 PDT -------
Created an attachment (id=9339)
--> (http://bugzilla.opendarwin.org/attachment.cgi?id=9339&action=view)
Patch v4
Changes since Patch v3:
(In reply to comment #27)
> (From update of attachment 9325 [edit])
> I'm concerned about adding another level of function call for every caller of
> toInt32, which might be hot. Maybe just repeat the code twice?
I hate duplicating code. I made the one-argument method inline in value.h. Is
that okay?
> I think the bool& parameter's purpose is not self-explanatory and so I think it
> should have a name in the header.
Added.
> I don't see the code to set $maybeOkParam!
This value is set from the return value of TypeCanFailConversion(), which is
the line of code in question below.
> + return 1; # 0; # or can it?
>
> The above line of code is confusing, even more than it was before.
Sorry...I left the old code in when first attempting to change the value. I
removed "# 0; # or can it?" in this patch.
--
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list