[Webkit-unassigned] [Bug 9179] Implement select.options.add() method

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=9179


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9325|review?                     |review-
               Flag|                            |




------- Comment #27 from darin at apple.com  2006-07-09 23:32 PDT -------
(From update of attachment 9325)
This seems nearly perfect even though I have a few minor quibbles.

I'm concerned about adding another level of function call for every caller of
toInt32, which might be hot. Maybe just repeat the code twice?

I think the bool& parameter's purpose is not self-explanatory and so I think it
should have a name in the header.

I don't see the code to set $maybeOkParam!

+    return 1; # 0; # or can it?

The above line of code is confusing, even more than it was before.

This is getting really close, but review- for now for at least some of these
questions.

This change looks really great. Lets get it landed!


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.