[Webkit-unassigned] [Bug 10274] Move to use PLATFORM() macros.

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10274


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjs at apple.com,
                   |                            |darin at apple.com,
                   |                            |ggaren at apple.com




------- Comment #3 from darin at apple.com  2006-08-06 11:09 PDT -------
(In reply to comment #2)
> (From update of attachment 9897 [edit])
> JSStringRef.h is a public header, so it can't include WTF stuff. That probably
> means we shouldn't use WTF in JSStringRef.cpp, either, because we want the
> header and implementation to use matching macros.

I think it's a mistake to have CF-related stuff in JSStringRef.h. I think we
should put the CoreFoundation bridging in a separate header rather than using
ifdefs. For one thing, there's no way to figure out whether CoreFoundation is
present and/or wanted with ifdefs. For example, there's the open source
CoreFoundation on Windows.

Inside the project we use the Platform.h macros for such things, but for public
headers that won't work. So I think a separate header is the best solution.
Geoff, Maciej, what do you think?


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.