[Webkit-unassigned] [Bug 10274] Move to use PLATFORM() macros.

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10274


ggaren at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9897|                            |review-
               Flag|                            |




------- Comment #2 from ggaren at apple.com  2006-08-06 11:03 PDT -------
(From update of attachment 9897)
JSStringRef.h is a public header, so it can't include WTF stuff. That probably
means we shouldn't use WTF in JSStringRef.cpp, either, because we want the
header and implementation to use matching macros.

PLATFORM(DARWIN) is probably the wrong test for CF-related code in JSStringRef*
and testapi.c, since CF isn't tied to Darwin. A CF-related test is probably
better.

PLATFORM(DARWIN) also seems wrong in kjs_*, since it's really about ObjC
support more than anything. PLATFORM(MAC), maybe?

Otherwise, this patch looks good.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.