[Webkit-unassigned] [Bug 8563] [DOMHTMLDocument doctype] always returning nil.

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Tue Apr 25 08:03:16 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #7940|review?                     |review-
               Flag|                            |

------- Comment #9 from darin at apple.com  2006-04-25 08:03 PDT -------
(From update of attachment 7940)
(In reply to comment #8)
> Do you have any objections to passing in a lowercase 'html' to new DocumentType
> in HTMLDocument::determineParseMode instead:
>      setDocType(new DocumentType(this, "html", publicID, systemID));

Sounds fine. We should do this.

> An even better fix, but one which is far more trouble than it is worth, would
> be to pass the same version of the name as read in from the <!Doctype ...>, but
> WebKit has already lost that information by the time the setDocType call is
> made.

I'm not sure why you say this is more trouble than it's worth, though.

We could easily add a fourth return value to the function
"parseDocTypeDeclaration" in HTMLDocument.cpp to complement the resultFlags,
publicID, and systemID return values.

I think the real issue is not the difficulty of implementation, but the
behavior of other browsers. Do those browsers always return the "html" in the
same case it was in the <!doctype> or do they always return lowercase "html"?
We should match them. If they always return lowercase "html", then this is not
a better fix after all.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list