[Webkit-unassigned] [Bug 8563] [DOMHTMLDocument doctype] always returning nil.

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8563





------- Comment #8 from matt at softchaos.com  2006-04-25 01:36 PDT -------
(In reply to comment #7)
> So I'm a bit uncomfortable with the change in hc_documentgetdoctype.js.
> 

As it stood before my patch that code (in the test) would never have been
called anyway (in WebKit)

The problem is caused by the test html file using 'html' but WebKit hard-coding
a 'HTML' for the docType. Conceptually, the test is consistent with itself and
so should probably not have been changed.

Do you have any objections to passing in a lowercase 'html' to new DocumentType
in HTMLDocument::determineParseMode instead:
     setDocType(new DocumentType(this, "html", publicID, systemID));

An even better fix, but one which is far more trouble than it is worth, would
be to pass the same version of the name as read in from the <!Doctype ...>, but
WebKit has already lost that information by the time the setDocType call is
made.

Since html is inherently case-insensitive anyway I see no issue with using
'html' instead and not changing the test.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.