[Webkit-unassigned] [Bug 8408] Paint the highlight behind selected list markers

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Apr 16 19:49:32 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=8408


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7744|review?                     |review+
               Flag|                            |




------- Comment #4 from darin at apple.com  2006-04-16 19:49 PDT -------
(From update of attachment 7744)
In RenderListMarker::selectionRect, I think it's a little strange to compute
selectionRight by adding width() to selectionLeft, then later just subtract
selectionLeft out. Instead we should either just use width() directly or have a
selectionWidth local variable.

Otherwise this looks perfect to me.

r=me with or without that change.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list