[Webkit-unassigned] [Bug 8408] Paint the highlight behind selected list markers

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sun Apr 16 08:15:14 PDT 2006


opendarwin.org at mitzpettel.com changed:

           What    |Removed                     |Added
Attachment #7727 is|0                           |1
           obsolete|                            |
   Attachment #7744|                            |review?
               Flag|                            |

------- Comment #3 from opendarwin.org at mitzpettel.com  2006-04-16 08:15 PDT -------
Created an attachment (id=7744)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7744&action=view)
Revised patch

(In reply to comment #2)
> Why isn't there a check of selectionState() inside the "isErrorImage" code
> path?

My mistake, corrected in this version.

> The 153 alpha thing from RenderReplaced is really ugly. I'd like it to be
> something more like this to make the 60% clear:
>     const int selectionColorImageOverlayAlpha = 60 * 255 / 100;
> If it was in a header file it could be shared with RenderReplaced.

Added in RenderObject.h.

> Is it really correct to set the selection state of the item to match the state
> of the list marker?

Yet another mistake. In this version I replaced the list item with the
containing block both in setSelecitonState() and in selectionRect().

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list