[webkit-reviews] review granted: [Bug 273826] AX: When a text input field is contained within an element with role combobox, the input field should inherit the role combobox. : [Attachment 471308] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 273826: AX: When a text input field is contained within an element with
role combobox, the input field should inherit the role combobox.
https://bugs.webkit.org/show_bug.cgi?id=273826

Attachment 471308: Patch

https://bugs.webkit.org/attachment.cgi?id=471308&action=review




--- Comment #8 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 471308
  --> https://bugs.webkit.org/attachment.cgi?id=471308
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471308&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:516
> +	   // Text fields may have a combobox ancestor, in which case we want
to return role combobox.

Sorry for missing this on the first round, but it might be nice to mention that
this was the ARIA 1.1 combobox pattern that has since been deprecated, but is
still used by some sites. Just so future us don't think this was an adhoc
decision to support this style of combobox.