[webkit-reviews] review granted: [Bug 176776] innerText getter fails tests for <p> without margin and <h1>-<h6> : [Attachment 471306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 7 18:05:39 PDT 2024


Ryosuke Niwa <rniwa at webkit.org> has granted Ahmad Saleem
<ahmad.saleem792 at gmail.com>'s request for review:
Bug 176776: innerText getter fails tests for <p> without margin and <h1>-<h6>
https://bugs.webkit.org/show_bug.cgi?id=176776

Attachment 471306: Patch

https://bugs.webkit.org/attachment.cgi?id=471306&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 471306
  --> https://bugs.webkit.org/attachment.cgi?id=471306
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471306&action=review

> Source/WebCore/editing/TextIterator.cpp:928
> +    if (RefPtr element = dynamicDowncast<HTMLElement>(node))

Why not just:
return node->hasTagName(pTag);


More information about the webkit-reviews mailing list