[webkit-reviews] review granted: [Bug 248202] [CMake] Use target_precompile_headers for Windows : [Attachment 463655] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 22 10:09:54 PST 2022


Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 248202: [CMake] Use target_precompile_headers for Windows
https://bugs.webkit.org/show_bug.cgi?id=248202

Attachment 463655: Patch

https://bugs.webkit.org/attachment.cgi?id=463655&action=review




--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 463655
  --> https://bugs.webkit.org/attachment.cgi?id=463655
Patch

r=me but I think you should think about adding a check for the CMake version
since 3.16 isn't the minimum its 3.12.


More information about the webkit-reviews mailing list