[webkit-reviews] review denied: [Bug 248197] [Filters] Introduce GraphicsStyle and add it to GraphicsContext and GraphicsContextState : [Attachment 463653] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 248197: [Filters] Introduce GraphicsStyle and add it to GraphicsContext and
GraphicsContextState
https://bugs.webkit.org/show_bug.cgi?id=248197

Attachment 463653: Patch

https://bugs.webkit.org/attachment.cgi?id=463653&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 463653
  --> https://bugs.webkit.org/attachment.cgi?id=463653
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=463653&action=review

I suggest you add DropShadow first, then add support for gaussian blur and
color matrix.

> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:193
> +struct CGGaussianBlurStyle {

These need to be wrapped in #if HAVE(CGSTYLE_COLORMATRIX_BLUR)

> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:210
> +    kCGStyleGaussianBlur = 3,

The new values need to be wrapped in HAVE(CGSTYLE_COLORMATRIX_BLUR)

> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:367
> +CGStyleRef CGStyleCreateGaussianBlur(const CGGaussianBlurStyle*);

These need to be wrapped in HAVE(CGSTYLE_COLORMATRIX_BLUR)