[webkit-reviews] review granted: [Bug 240137] Several tests fail because CFImageSourceCreateImageAtIndex premultiplies alpha with PNG files for iOS family devices : [Attachment 459198] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 12 15:28:07 PDT 2022


Simon Fraser (smfr) <simon.fraser at apple.com> has granted John Cunningham
<johncunningham at apple.com>'s request for review:
Bug 240137: Several tests fail because CFImageSourceCreateImageAtIndex
premultiplies alpha with PNG files for iOS family devices
https://bugs.webkit.org/show_bug.cgi?id=240137

Attachment 459198: Patch

https://bugs.webkit.org/attachment.cgi?id=459198&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 459198
  --> https://bugs.webkit.org/attachment.cgi?id=459198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459198&action=review

> Source/WTF/ChangeLog:4
> +	   https://bugs.webkit.org/show_bug.cgi?id=240137

There should be a radar here too, in particular so we can correlate it with
internal layout tests.

> Source/WTF/wtf/PlatformHave.h:1170
> +#define HAVE_IMAGE_IO_CREATE_UNPREMULTIPLIED_PNG 1

Elsewhere we use HAVE_IMAGEIO_


More information about the webkit-reviews mailing list