[webkit-reviews] review granted: [Bug 240326] Web Inspector: support EventSource resource type in Network Panel : [Attachment 459250] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 240326: Web Inspector: support EventSource resource type in Network Panel
https://bugs.webkit.org/show_bug.cgi?id=240326

Attachment 459250: Patch

https://bugs.webkit.org/attachment.cgi?id=459250&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 459250
  --> https://bugs.webkit.org/attachment.cgi?id=459250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=459250&action=review

r=me, neat!

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:647
> +/* Display name for the type of network requests sent via EventSource API
(https://developer.mozilla.org/en-US/docs/Web/API/EventSource) */

This needs to be added in the `WI.UIString` in the code as well, as otherwise
the next time someone generates this file it wont have this comment.
```
WI.UIString("EventSource", "Display name for the type of network requests sent
via EventSource API
(https://developer.mozilla.org/en-US/docs/Web/API/EventSource)")
```

> Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:649
> +localizedStrings["EventSources"] = "EventSources";

please also add a similar comment for this too :)