[webkit-reviews] review granted: [Bug 240063] [Mac] WebCore should search system content path for nested Frameworks : [Attachment 458791] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 240063: [Mac] WebCore should search system content path for nested
Frameworks
https://bugs.webkit.org/show_bug.cgi?id=240063

Attachment 458791: Patch

https://bugs.webkit.org/attachment.cgi?id=458791&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 458791
  --> https://bugs.webkit.org/attachment.cgi?id=458791
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=458791&action=review

>> Source/WebCore/Configurations/WebCore.xcconfig:66
>>  WK_FRAMEWORKS_LIBRARY_DIR_USE_ALTERNATE_FRAMEWORKS_DIR_YES =
$(WK_ALTERNATE_FRAMEWORKS_DIR)/$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks/WebCore.
framework/Versions/A/Frameworks;
> 
> Do we want $(INSTALL_PATH_PREFIX) here too? I believe this path is used for
catalyst builds, where WK_ALTERNATE_FRAMEWORKS_DIR = /System/iOSSupport.

Great catch, I think that we need the same change for macCatalyst too.
Surprised that building with the patch didn't fail macCatalyst build.