[webkit-reviews] review granted: [Bug 240063] [Mac] WebCore should search system content path for nested Frameworks : [Attachment 458791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 10:24:18 PDT 2022

Alexey Proskuryakov <ap at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 240063: [Mac] WebCore should search system content path for nested

Attachment 458791: Patch


--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 458791
  --> https://bugs.webkit.org/attachment.cgi?id=458791

View in context: https://bugs.webkit.org/attachment.cgi?id=458791&action=review

>> Source/WebCore/Configurations/WebCore.xcconfig:66
> Do we want $(INSTALL_PATH_PREFIX) here too? I believe this path is used for
catalyst builds, where WK_ALTERNATE_FRAMEWORKS_DIR = /System/iOSSupport.

Great catch, I think that we need the same change for macCatalyst too.
Surprised that building with the patch didn't fail macCatalyst build.

More information about the webkit-reviews mailing list