[webkit-reviews] review denied: [Bug 239876] Speed-up querySelectorAll() with single by-class selector : [Attachment 458619] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 4 10:01:24 PDT 2022

Ryosuke Niwa <rniwa at webkit.org> has denied Alexey Shvayka
<ashvayka at apple.com>'s request for review:
Bug 239876: Speed-up querySelectorAll() with single by-class selector

Attachment 458619: Patch


--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 458619
  --> https://bugs.webkit.org/attachment.cgi?id=458619

View in context: https://bugs.webkit.org/attachment.cgi?id=458619&action=review

> Source/WTF/wtf/RefCountedVector.h:35
> +class RefCountedVector final : public RefCounted<RefCountedVector<T>>,
public Vector<T> {

What's the point of this class??

> Source/WebCore/dom/CollectionIndexCache.h:40
> +    using CachedListType = RefCountedVector<Ref<NodeType>>;

We can't use Ref here. This will result in a leak since we don't automatically
clear collection cache when a subtree is detached.
r- because of this.

More information about the webkit-reviews mailing list