[webkit-reviews] review granted: [Bug 237165] [ BigSur+ Debug wk2 EWS ] imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/quirks.window.html is a flaky crash : [Attachment 455259] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 237165: [ BigSur+ Debug wk2 EWS ]
imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/openin
g-the-input-stream/quirks.window.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=237165

Attachment 455259: Patch

https://bugs.webkit.org/attachment.cgi?id=455259&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 455259
  --> https://bugs.webkit.org/attachment.cgi?id=455259
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455259&action=review

r=me with changes.

> Source/WebKit/WebProcess/WebStorage/StorageAreaMap.cpp:360
>      auto completionHandler = [this, weakThis = WeakPtr { *this },
weakConnection = WeakPtr { ipcConnection }](auto remoteAreaIdentifier, auto
items, auto messageIdentifier) mutable {

Seems to be capturing the ipcConnection unnecessarily now.