[webkit-reviews] review granted: [Bug 238169] Add logging for LocalStorage and IndexedDB data migration : [Attachment 455563] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 238169: Add logging for LocalStorage and IndexedDB data migration
https://bugs.webkit.org/show_bug.cgi?id=238169

Attachment 455563: Patch

https://bugs.webkit.org/attachment.cgi?id=455563&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 455563
  --> https://bugs.webkit.org/attachment.cgi?id=455563
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455563&action=review

r=me

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:358
> +	       RELEASE_LOG(Storage, "%p -
StorageBucket::resolvedLocalStoragePath New path '%s'", this,
localStoragePath.utf8().data());

%{public}s if you want to see the path in public builds.

Given that the paths do not contain any origin information, I think it's OK.

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:389
> +	   RELEASE_LOG(Storage, "%p - StorageBucket::resolvedIDBStoragePath New
path '%s'", this, idbStoragePath.utf8().data());

%{public}s