[webkit-reviews] review granted: [Bug 235047] Web Inspector: Inline swatch popovers should hide when inline swatches are removed : [Attachment 454726] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 21 16:31:32 PDT 2022


Patrick Angle <pangle at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 235047: Web Inspector: Inline swatch popovers should hide when inline
swatches are removed
https://bugs.webkit.org/show_bug.cgi?id=235047

Attachment 454726: Patch

https://bugs.webkit.org/attachment.cgi?id=454726&action=review




--- Comment #9 from Patrick Angle <pangle at apple.com> ---
Comment on attachment 454726
  --> https://bugs.webkit.org/attachment.cgi?id=454726
Patch

r=me

Is it possible for us to fix this more holistically? This patch works, but only
fixes the contextual documentation and inline swatch popovers, but the same
issue actually exists for all the other popovers in Web Inspector. I can
reproduce this by showing any popover in the frontend, and then from the
Develop menu in Safari choosing "Show JavaScript Console" to jump to the
console. Also reproduces if I use a Web Inspector keyboard shortcut like
Shift+Cmd+F to jump to the search tab. I think long-term MutationObserver and
having Popover handle this logic itself (which will require making Popover
aware of the element it is supposed to be attached to) will be a much better
solution. In the interim, I think what you have here is fine though unless you
think we might already be close to just solving this with MutationObserver. If
we aren't, and we land this patch, please just open a bug to track a more
general solution that also removes these changes.


More information about the webkit-reviews mailing list