[webkit-reviews] review granted: [Bug 238160] It should be possible to copy text out of “AutoFilledAndViewable” password fields : [Attachment 455294] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ricky Mondello
<rmondello at apple.com>'s request for review:
Bug 238160: It should be possible to copy text out of “AutoFilledAndViewable”
password fields
https://bugs.webkit.org/show_bug.cgi?id=238160

Attachment 455294: Patch

https://bugs.webkit.org/attachment.cgi?id=455294&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 455294
  --> https://bugs.webkit.org/attachment.cgi?id=455294
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455294&action=review

r=me

> Source/WebCore/editing/VisibleSelection.cpp:686
> +bool VisibleSelection::isInAutoFilledAndViewablePasswordField() const

I think this helper function's usage would be more straight-forward if the
function only computed "isInAutoFilledAndViewableField" and not also
"isInPasswordField" -- since the caller already checks whether the selection is
in a password field.