[webkit-reviews] review granted: [Bug 237890] [CSS Container Queries] Some more WPT updates : [Attachment 454703] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 15 07:00:07 PDT 2022


Antoine Quint <graouts at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 237890: [CSS Container Queries] Some more WPT updates
https://bugs.webkit.org/show_bug.cgi?id=237890

Attachment 454703: Patch

https://bugs.webkit.org/attachment.cgi?id=454703&action=review




--- Comment #2 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 454703
  --> https://bugs.webkit.org/attachment.cgi?id=454703
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454703&action=review

>
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/c
anvas-as-container-005.html:24
> +  setup(() => assert_implements_container_queries());

Wouldn't `setup(assert_implements_container_queries)` just work here?

>
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/d
isplay-none.html:367
> +    test(function() {

You can use `() =>`.


More information about the webkit-reviews mailing list