[webkit-reviews] review granted: [Bug 236441] Make MIMETypeRegistry::mimeTypeForPath take a StringView : [Attachment 454679] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 15 07:14:12 PDT 2022
Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 236441: Make MIMETypeRegistry::mimeTypeForPath take a StringView
https://bugs.webkit.org/show_bug.cgi?id=236441
Attachment 454679: Patch
https://bugs.webkit.org/attachment.cgi?id=454679&action=review
--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454679
--> https://bugs.webkit.org/attachment.cgi?id=454679
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=454679&action=review
r=me with fix.
> Source/WebCore/platform/MIMETypeRegistry.cpp:402
> + auto result = mimeTypeForExtension(path.substring(position +
1).toString());
There should be no .toString() here.
More information about the webkit-reviews
mailing list