[webkit-reviews] review granted: [Bug 237641] [Selection] Fixes selection range settings for TEXTAREA : [Attachment 454581] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted zsun at igalia.com's request for
review:
Bug 237641: [Selection] Fixes selection range settings for TEXTAREA
https://bugs.webkit.org/show_bug.cgi?id=237641

Attachment 454581: Patch

https://bugs.webkit.org/attachment.cgi?id=454581&action=review




--- Comment #8 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454581
  --> https://bugs.webkit.org/attachment.cgi?id=454581
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454581&action=review

r=me

> Source/WebCore/html/HTMLTextFormControlElement.cpp:316
> +    RefPtr<Frame> frame = document().frame();

RefPtr frame = document().frame();

> Source/WebCore/html/TextFieldInputType.cpp:148
> +	   unsigned max = visibleValue().length();

nit: I would use auto.