[webkit-reviews] review granted: [Bug 237720] [selection] HTMLTextFormControlElement::subtreeHasChanged() shouldn't be called in setRangeText : [Attachment 454372] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted zsun at igalia.com's request for
review:
Bug 237720: [selection] HTMLTextFormControlElement::subtreeHasChanged()
shouldn't be called in setRangeText
https://bugs.webkit.org/show_bug.cgi?id=237720

Attachment 454372: Patch

https://bugs.webkit.org/attachment.cgi?id=454372&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454372
  --> https://bugs.webkit.org/attachment.cgi?id=454372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454372&action=review

r=me

> Source/WebCore/ChangeLog:8
> +	   We shouldn't call HTMLTextFormControlElement::subtreeHasChanged() 
in HTMLTextFormControlElement::setRangeText.

nit: extra space before "in"

> Source/WebCore/ChangeLog:11
> +	   This cl refers and imports some of the changes in chromiu CL at

I think "cl" is a chrome/blink term.

Also typo: chromiu