[webkit-reviews] review denied: [Bug 237567] [WebAuthn] Support authenticatorSelection.residentKey ResidentKeyRequirement : [Attachment 454138] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied  review:
Bug 237567: [WebAuthn] Support authenticatorSelection.residentKey
ResidentKeyRequirement
https://bugs.webkit.org/show_bug.cgi?id=237567

Attachment 454138: Patch

https://bugs.webkit.org/attachment.cgi?id=454138&action=review




--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 454138
  --> https://bugs.webkit.org/attachment.cgi?id=454138
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454138&action=review

> Source/WebCore/Modules/webauthn/PublicKeyCredentialCreationOptions.h:141
> +	   return std::nullopt;

This never sets residentKey on result. It is decoding and ignoring the value.

I haven't looked at the rest of the patch yet but r- due to this bug.