[webkit-reviews] review granted: [Bug 235112] AssemblyHelpersSpoolers: use load/store pair on ARMv7 : [Attachment 449333] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zan at falconsigh.net> has granted Angelos Oikonomopoulos
<angelos at igalia.com>'s request for review:
Bug 235112: AssemblyHelpersSpoolers: use load/store pair on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=235112

Attachment 449333: Patch

https://bugs.webkit.org/attachment.cgi?id=449333&action=review




--- Comment #10 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 449333
  --> https://bugs.webkit.org/attachment.cgi?id=449333
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=449333&action=review

> Source/JavaScriptCore/jit/AssemblyHelpersSpoolers.h:284
> +#if !(CPU(ARM64) || CPU(ARM))
> +	   if constexpr (hasPairOp)
>	       RELEASE_ASSERT_NOT_REACHED(); // unsupported architecture.
> +#endif

Honestly unguarded constexpr with additional `&& !isARM()` (if it existed)
would be nicer.