[webkit-reviews] review granted: [Bug 237469] Add hasTransformOrPerspective() helper to RenderObject : [Attachment 453834] Patch, v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 237469: Add hasTransformOrPerspective() helper to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=237469

Attachment 453834: Patch, v1

https://bugs.webkit.org/attachment.cgi?id=453834&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 453834
  --> https://bugs.webkit.org/attachment.cgi?id=453834
Patch, v1

View in context: https://bugs.webkit.org/attachment.cgi?id=453834&action=review

I wonder at what point these function implementations get long enough that we
want to move them out of the class definition.	They can still be in the header
if they need to be inlined or in the .cpp file if not. Probably not yet but
they are certainly getting close.

> Source/WebCore/ChangeLog:3
> +	   Add hasTransformOrPerspective() helper to RenderObject

The rationale in the change log explains in detail why we must use hasTransform
here, but says nothing about why adding hasTransdormOrPerspective is good.